Return-path: Received: from wf-out-1314.google.com ([209.85.200.174]:65100 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbYJQVP0 (ORCPT ); Fri, 17 Oct 2008 17:15:26 -0400 Received: by wf-out-1314.google.com with SMTP id 27so835783wfd.4 for ; Fri, 17 Oct 2008 14:15:25 -0700 (PDT) Message-ID: <40f31dec0810171415t37e151fdy40841048e5400cf1@mail.gmail.com> (sfid-20081017_231530_203227_F2D94442) Date: Sat, 18 Oct 2008 00:15:25 +0300 From: "Nick Kossifidis" To: "Bob Copeland" , "John W. Linville" Subject: Re: [PATCH] ath5k: reduce checkpatch.pl errors Cc: "John Daiker" , jirislaby@gmail.com, mcgrof@gmail.com, linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <48F8E470.8000103@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: 2008/10/17 Bob Copeland : > On Fri, Oct 17, 2008 at 3:16 PM, John Daiker wrote: >> A few changes to reduce checkpatch.pl errors in the ath5k driver. For the >> most part, I only fixed cosmetic things, and left the actual 'code flow' >> untouched (hopefully)! >> >> Diff is against wireless-testing HEAD. >> >> Signed-off-by: John Daiker > > Please post patches inline if you can; they are easier to review that way. > > One easy way to convince yourself (and us) that there are no code changes > is to compile with and without the patch and compare resulting binaries > for no differences. > > All that said, I reviewed this one and it looks good... > > Reviewed-by: Bob Copeland > > -- > Bob Copeland %% www.bobcopeland.com > Same here... Acked-by: Nick Kossifidis -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick