Return-path: Received: from mail-gx0-f16.google.com ([209.85.217.16]:57812 "EHLO mail-gx0-f16.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbYJTIzq (ORCPT ); Mon, 20 Oct 2008 04:55:46 -0400 Received: by gxk9 with SMTP id 9so3328799gxk.13 for ; Mon, 20 Oct 2008 01:55:45 -0700 (PDT) Message-ID: <43e72e890810200155wbe01660xe3f53de80dc7357d@mail.gmail.com> (sfid-20081020_105549_875820_82243382) Date: Mon, 20 Oct 2008 01:55:45 -0700 From: "Luis R. Rodriguez" To: Sujith Subject: Re: [RFC] mac80211: Re-enable aggregation Cc: "Johannes Berg" , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "Luis Rodriguez" , "tomasw@gmail.com" In-Reply-To: <18684.17816.702853.44986@gargle.gargle.HOWL> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <18684.16351.638713.791015@gargle.gargle.HOWL> <1224491480.18024.32.camel@johannes.berg> <43e72e890810200135o1581c904i456a35298f8a56a9@mail.gmail.com> <1224492335.18024.34.camel@johannes.berg> <18684.17816.702853.44986@gargle.gargle.HOWL> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Oct 20, 2008 at 1:47 AM, Sujith wrote: > Johannes Berg wrote: > > On Mon, 2008-10-20 at 01:35 -0700, Luis R. Rodriguez wrote: > > > > > >> + * @is_part_ampdu: set to indicate that the wireless core should should > > > >> + * treat this frame as part of an AMPDU > > > > > > > > I thought we said we could keep the flag instead of moving to the skb > > > > here? > > > > > > That was just because the changes required to add this was too much > > > for 2.6.27 but since we don't care about this fix in 2.6.27 we can do > > > whatever is needed to fix this properly. > > > > Right, but adding random stuff into skb isn't really "properly" imho. > > And we don't really need this afaict. > > > > Sorry, just saw that Tomas had fixed it by setting the flag in ieee80211_tx_h_sequence(). > Will fix that. No that was a hack too, this was to minimize code changes for 2.6.27 as well. Luis