Return-path: Received: from mail-gx0-f16.google.com ([209.85.217.16]:38330 "EHLO mail-gx0-f16.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbYJUSIn (ORCPT ); Tue, 21 Oct 2008 14:08:43 -0400 Received: by gxk9 with SMTP id 9so6003195gxk.13 for ; Tue, 21 Oct 2008 11:08:42 -0700 (PDT) Message-ID: <40f31dec0810211108l6700d806o4804b43d9fe47bf7@mail.gmail.com> (sfid-20081021_200848_842322_8692A2EA) Date: Tue, 21 Oct 2008 21:08:41 +0300 From: "Nick Kossifidis" To: "Jiri Slaby" , "Gregory Nietsky" Subject: Re: [PATCH 1/1] Ath5k: add AP mode Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath5k-devel@venema.h4ckr.net, "Luis R. Rodriguez" In-Reply-To: <1223844850-26551-1-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <1223844850-26551-1-git-send-email-jirislaby@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: 2008/10/12 Jiri Slaby : > Add support for AP mode. This involves: > - enablement in ath5k_beacon_config -- initialize beacon timer > - add AP to the supported modes in ath5k_add_interface > - handle beacon change even for AP in ath5k_config_interface > - remove useless test for IBSS in ath5k_beacon_update > > Note that it doesn't enable the AP mode for the driver. It must > be enabled by NL80211_IFTYPE_AP bit added to interface_modes. > > v2: > Fixed opmode constant (IEEE80211_ to NL80211_) > > Signed-off-by: Jiri Slaby > Cc: Nick Kossifidis > Cc: Luis R. Rodriguez a) It won't work without the following as Gregory pointed out diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index e09ed2c..69aad6e 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -488,6 +488,7 @@ ath5k_pci_probe(struct pci_dev *pdev, hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | + BIT(NL80211_IFTYPE_AP) | BIT(NL80211_IFTYPE_ADHOC) | BIT(NL80211_IFTYPE_MESH_POINT); b) For some reason it only works with 5212/5213 cards, i tested it on a 5413 and an 2425 and it didn't work (hostapd seems to hang). -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick