Return-path: Received: from kroah.org ([198.145.64.141]:52330 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753700AbYJ1SUW (ORCPT ); Tue, 28 Oct 2008 14:20:22 -0400 Date: Tue, 28 Oct 2008 10:09:31 -0700 From: Greg KH To: Luis Correia Cc: "Luis R. Rodriguez" , Johannes Berg , Thorsten Leemhuis , rt2400-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org Subject: Re: rtl2860 driver in mainline? Message-ID: <20081028170931.GB4818@kroah.com> (sfid-20081028_192029_890539_EE6317A1) References: <20081028004915.GA3442@kroah.com> <4906B944.4010105@leemhuis.info> <1225180598.3796.66.camel@johannes.berg> <43e72e890810280102i3df34e2h9bf281c5d1e00a48@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Oct 28, 2008 at 08:06:39AM +0000, Luis Correia wrote: > Hi > > On Tue, Oct 28, 2008 at 08:02, Luis R. Rodriguez wrote: > > On Tue, Oct 28, 2008 at 12:56 AM, Johannes Berg > > wrote: > >> On Tue, 2008-10-28 at 08:03 +0100, Thorsten Leemhuis wrote: > >>> On 28.10.2008 01:49, Greg KH wrote: > >>> > So, on my quest to suck up every out-of-tree driver and get it into the > >>> > main kernel tree (drivers/staging/ to start with), I've been pointed at > >>> > the rtl2860 driver. > >>> > >>> Does it really make sense to include a driver when a different one for > >>> mainline inclusion is being actively developed? It might give some > >>> developers the impression that it's worth spending time improving the > >>> rtl2860/2870 drivers -- which might be wasted time in the end. > >> > >> I don't think it makes sense either, at _best_ it'll do nothing but help > >> a few users [1], and if somebody actually starts working on the vendor > >> driver because it's in staging that's actively harmful to the real > >> driver by diverting resources away from it. > >> > >> johannes > >> > >> [1] I used to think the point wasn't to make users happy but to make it > >> easier to work on those drivers, but that objective seems long gone > > > > Problem is distributions already ship crap anyway. > > Exactly, last April I realised that Caixa Magica (the Portuguese > Mandriva spinoff) already had two drivers for Ralink chipsets, being > that it even had wrong usb ID's in the code. (a rtl8187 was identified > as rt72usb..) It is this kind of problem that I am trying to address here. If these drivers are in the kernel, then this stuff can easily be fixed, so the distros can't get it wrong (well, it will take some effort on their part to get it wrong...) thanks, greg k-h