Return-path: Received: from mail-gx0-f16.google.com ([209.85.217.16]:45294 "EHLO mail-gx0-f16.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbYJTGqH (ORCPT ); Mon, 20 Oct 2008 02:46:07 -0400 Received: by gxk9 with SMTP id 9so3263860gxk.13 for ; Sun, 19 Oct 2008 23:46:06 -0700 (PDT) Message-ID: <43e72e890810192346q5e0eadbcm26febe45392a2172@mail.gmail.com> (sfid-20081020_084612_465430_E7214D39) Date: Sun, 19 Oct 2008 23:46:06 -0700 From: "Luis R. Rodriguez" To: "Johannes Berg" Subject: Re: New Regulatory Domain Api. Cc: "Zhu Yi" , "Luis Rodriguez" , "Tomas Winkler" , "Marcel Holtmann" , "John W. Linville" , "Kolekar, Abhijeet" , "linux-wireless@vger.kernel.org" In-Reply-To: <1224484685.18024.5.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <20081015112517.GF6509@tesla> <1ba2fa240810151757r11060dfble6b58c76a7d0d8d1@mail.gmail.com> <20081015185636.GH15902@tesla> <1224126030.24677.78.camel@debian.sh.intel.com> <20081016113848.GB5899@tesla> <1224471102.24677.124.camel@debian.sh.intel.com> <43e72e890810192040w567fa4f6j1bf40e80084a857e@mail.gmail.com> <1224479933.24677.148.camel@debian.sh.intel.com> <43e72e890810192333r7b3f6a0m56d499d0aed9240e@mail.gmail.com> <1224484685.18024.5.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Oct 19, 2008 at 11:38 PM, Johannes Berg wrote: > On Sun, 2008-10-19 at 23:33 -0700, Luis R. Rodriguez wrote: > >> Well the code specifically disregards secondary regulatory_hint()'s >> right now and we reviewed why -- we discussed it at OLS and agreed to >> go with the first one as that will usually be the built in one. That's >> why. The restrictive thing to do next to handle more cards better is >> to keep doing intersections. > > If we're going to disregard 5 GHz for the first hint if there's no > information on it, then we should take the first hint containing 5 GHz > information seriously imho. Sure but an issue here is that if we do deal with band-specific regulatory domain definitions we change the regulatory behavior from being "disallow everything first" to "allow everything first, disable everything in the band for which we encounter a rule in except what the rule allows". Since the regulatory definitions in db.txt are in KHz we are allowing it to grow as more technology pops up with support for more bands. I think the first approach was better. The current suggestion of only applying rules if a band reg definition is present is only to deal with a rare case. I think its better we try to handle that instead and keep our existing behaviour. Luis