Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:51783 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbYJGUBr (ORCPT ); Tue, 7 Oct 2008 16:01:47 -0400 Received: by fg-out-1718.google.com with SMTP id 19so2439928fgg.17 for ; Tue, 07 Oct 2008 13:01:45 -0700 (PDT) Message-ID: <1ba2fa240810071301k185eebf6qbca6841af120e0ea@mail.gmail.com> (sfid-20081007_220151_587413_BADD4D6B) Date: Tue, 7 Oct 2008 22:01:45 +0200 From: "Tomas Winkler" To: "Johannes Berg" Subject: Re: [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap Cc: "John W. Linville" , "Christoph Hellwig" , "Holger Schurig" , linux-wireless@vger.kernel.org In-Reply-To: <1223408085.3618.2.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1223311803.15196.36.camel@johannes.berg> <1ba2fa240810061135t24f2dfbv2a5eb0cd5d9e8cd7@mail.gmail.com> <200810070821.56462.hs4233@mail.mn-solutions.de> <20081007071529.GA5010@infradead.org> <20081007131615.GR3448@tuxdriver.com> <1ba2fa240810070703j471faa30mce3678febf3c20e8@mail.gmail.com> <1223398724.7328.45.camel@johannes.berg> <1ba2fa240810071228m52a60861r5558529426b9b487@mail.gmail.com> <1223408085.3618.2.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Oct 7, 2008 at 9:34 PM, Johannes Berg wrote: > On Tue, 2008-10-07 at 21:28 +0200, Tomas Winkler wrote: > >> > And please keep the 10 pairs -> 20 addresses, it's a lot easier to >> > understand :) > >> I don't like on this solution two things one is that it 32 bit >> variables sits on unaligned address > > That doesn't matter at all since it's packed, and the bitwise accesses > you did previously are way less efficient. This is not packet this is shared memory. Tomas