From: Elias Oltmanns <eo@nebensachen.de>
To: "Nick Kossifidis" <mickflemm@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	"Jiri Slaby" <jirislaby@gmail.com>,
	"Luis R. Rodriguez" <mcgrof@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Fix reset sequence for AR5212 in general and RF5111 in particular
References: <87prlr9mna.fsf@denkblock.local>
	<40f31dec0810251621l3d720a69mf21b5253e9135010@mail.gmail.com>
	<87abcrtfa8.fsf@denkblock.local>
	<40f31dec0810261132w2747d66em2a2a53ff9e1ecc04@mail.gmail.com>
	<87wsfvt76q.fsf@denkblock.local>
	<40f31dec0810261533g3143bd9bue0f3eff88c6936e9@mail.gmail.com>
Date: Sun, 26 Oct 2008 23:52:47 +0100
In-Reply-To: <40f31dec0810261533g3143bd9bue0f3eff88c6936e9@mail.gmail.com>
	(Nick Kossifidis's message of "Mon, 27 Oct 2008 00:33:40 +0200")
Message-ID: <87r663t1ds.fsf@denkblock.local> (sfid-20081026_235324_501794_81C2111B)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org

"Nick Kossifidis" <mickflemm@gmail.com> wrote:
> 2008/10/26 Elias Oltmanns <eo@nebensachen.de>:
>>
>
>>                /*
>>                 * Write some more initial register settings
>>                 */
>> -               if (ah->ah_version == AR5K_AR5212) {
>> +               if (ah->ah_version == AR5K_AR5212 &&
>> +                   ah->ah_radio > AR5K_RF5111) {
>
> even better: ah->ah_phy_revision > AR5K_SREV_PHY_5212

Just to be absolutely sure: ah->ah_phy_revision >= AR5K_SREV_PHY_5212
right?

>
>>                        ath5k_hw_reg_write(ah, 0x0002a002, 0x982c);
>>
>>                        if (channel->hw_value == CHANNEL_G)
>> @@ -858,6 +859,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum ieee80211_if_types op_mode,
>>
>>                        data = ath5k_hw_reg_read(ah, 0xa228);
>>                        data &= 0xfffe03ff;
>> +                       data |= 0x00000800;
>>                        ath5k_hw_reg_write(ah, data, 0xa228);
>>                        data = 0;
>>
>
> Can you please use the macros from ath5k.h to set these parameters ?
> (i got the above from decompiling binary HAL that's why i have fixed
> masks -no magic values- but now that we know what's going on we must
> make the code human-readable)
> And also please change 0xa228 with it's name from reg.h :
>
> 2557 #define AR5K_PHY_DAG_CCK_CTL                    0xa228
> 2558 #define AR5K_PHY_DAG_CCK_CTL_EN_RSSI_THR        0x00000200
> 2559 #define AR5K_PHY_DAG_CCK_CTL_RSSI_THR           0x0001fc00
> 2560 #define AR5K_PHY_DAG_CCK_CTL_RSSI_THR_S         10
>
> Normaly i'll update reset.c this week so you can always wait for a
> more generic fix ;-)

Well, I'm always happy to leave the work to others ;-). The only reason
why I kept resending patches was to make sure that a minimal fix would
get merged into a stable release eventually. Presumably, a rework of the
reset sequence in itself would not be appropriate for stable. Still, if
you'll take care get something into stable, that's fine with me.
Otherwise, just let me know and I'll keep those patches coming and you
occupied reviewing them ;-).

Regards,

Elias