Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:49623 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751728AbYJGHPb (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Tue, 7 Oct 2008 03:15:31 -0400
Date: Tue, 7 Oct 2008 03:15:29 -0400
From: Christoph Hellwig <hch@infradead.org>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, Tomas Winkler <tomasw@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] iwlwifi: get rid of IWL_{GET,SET}_BITS crap
Message-ID: <20081007071529.GA5010@infradead.org> (sfid-20081007_091535_384421_39BBE551)
References: <1223311803.15196.36.camel@johannes.berg> <1ba2fa240810061135t24f2dfbv2a5eb0cd5d9e8cd7@mail.gmail.com> <200810070821.56462.hs4233@mail.mn-solutions.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <200810070821.56462.hs4233@mail.mn-solutions.de>
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Tue, Oct 07, 2008 at 08:21:56AM +0200, Holger Schurig wrote:
> > I don't want these macros eithers but I NACK any patches with
> > cursing in the commit logs.
> 
> I fully agree. There's no need to speak about "crap" when 
> changing other people's code. In some cultures thats quite 
> insulting.

Well, it is crap.  Looks at it objectively.  It's a perfectly fine
description and most of us use it perfectly happily for our own code,
too.