Return-path: Received: from yw-out-2324.google.com ([74.125.46.28]:18089 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbYKDTTM (ORCPT ); Tue, 4 Nov 2008 14:19:12 -0500 Received: by yw-out-2324.google.com with SMTP id 9so1257955ywe.1 for ; Tue, 04 Nov 2008 11:19:11 -0800 (PST) Message-ID: <43e72e890811041119w57fd838ex84c9b18f3dd3ba23@mail.gmail.com> (sfid-20081104_201917_513763_9BC6F144) Date: Tue, 4 Nov 2008 11:19:10 -0800 From: "Luis R. Rodriguez" To: "Bob Copeland" Subject: Re: [PATCH] ath5k: enable RXing beacons Cc: "Dan Williams" , linville@tuxdriver.com, linux-wireless@vger.kernel.org, nbd@openwrt.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <1225672612-15106-1-git-send-email-lrodriguez@atheros.com> <1225676353.13684.2.camel@localhost.localdomain> <43e72e890811022043t5525d924vcb776569a7bebbc8@mail.gmail.com> <43e72e890811022049l386789f5qf8bde98eedcd4d2c@mail.gmail.com> <43e72e890811022052n8c5e7d3ic722caa65c711481@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Nov 4, 2008 at 4:37 AM, Bob Copeland wrote: > On Mon, Nov 3, 2008 at 10:17 AM, Bob Copeland wrote: >> On Sun, Nov 2, 2008 at 11:52 PM, Luis R. Rodriguez wrote: >>>>>> Sorry, my fault, this was a direct result of >>>>>> 60c7e22196fb4230b76db1f5fb283e811b8f3fb3 "ath5k: honor >> [...] >>> OK Vasanth confirmed this is correct, and ath9k actually has incorrect >>> behavior so we have to fix that there as well. If stable got the ath5k >>> changes to the filter then yes we should push it there too. > > BTW perhaps we should still look at the filter for ath5k since, once > associated, we still get beacons from every AP in the world instead of > just those with our BSSID. > > FIF_BCN_PRBRESP_PROMISC > > This flag is set during scanning to indicate to the hardware > that it should not filter beacons or probe responses by BSSID. > Filtering them can greatly reduce the amount of processing > mac80211 needs to do and the amount of CPU wakeups, so > you should honour this flag if possible. > > Right now with ath5k there's basically no difference between having or > not having that flag in station mode, even though we do set the bssid > in ath5k_hw_set_associd AFAICT. Agreed, what we would need is as Johannes has been suggesting a way to implement this properly in mac80211. Come to think of it mac80211 also isn't aware of all the other filter flags ath5k/ath9k devices are capable of, I'd be inclined to move all that to mac80211 that way mac80211 *always* tells us the exact filter flags needed and we don't get some strange internal mode checks as we do now. I posted a strategy we can take in the other thread to handle the beacon filter in mac80211, let me know what you think. Luis