Return-path: Received: from gprs189-60.eurotel.cz ([160.218.189.60]:38529 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbYKSSDM (ORCPT ); Wed, 19 Nov 2008 13:03:12 -0500 Date: Wed, 19 Nov 2008 12:28:23 +0100 From: Pavel Machek To: Christoph Hellwig Cc: kernel list , Greg KH , kaszak@gmail.com, lcostantino@gmail.com, linux-wireless@vger.kernel.org Subject: Re: w35und wifi driver for linux-staging Message-ID: <20081119112823.GD21876@elf.ucw.cz> (sfid-20081119_190317_476651_44981ADA) References: <20081001123656.GA30942@elf.ucw.cz> <20081001125248.GA29661@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20081001125248.GA29661@infradead.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed 2008-10-01 08:52:48, Christoph Hellwig wrote: > On Wed, Oct 01, 2008 at 02:36:56PM +0200, Pavel Machek wrote: > > +source "drivers/net/wireless/winbond/Kconfig" > > winbond is a little too generic, please use the same name as the driver > name for the directory. > > > @@ -0,0 +1,6 @@ > > +config W35UND > > + tristate "Winbond driver" > > + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL && !4KSTACKS > > + ---help--- > > + This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks > > + Check http://code.google.com/p/winbondport/ for new version > > Again, please give the option a useful name, and a useful description > including mentioning the actual chip name in there. > > Also the !4KSTACKS dependency looks rather odd. Fixed now, will sent patch shortly. > No comments on the code now, I don't think I want to look at it.. No, you don't want to :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html