Return-path: Received: from hostap.isc.org ([149.20.54.63]:33097 "EHLO hostap.isc.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbYKZHzW (ORCPT ); Wed, 26 Nov 2008 02:55:22 -0500 Date: Wed, 26 Nov 2008 09:55:07 +0200 From: Jouni Malinen To: Sujith Cc: Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: [RFC] nl80211: Add frequency configuration (including HT40) Message-ID: <20081126075507.GB31499@jm.kir.nu> (sfid-20081126_085525_682610_89AD331F) References: <20081125190533.GA27879@jm.kir.nu> <18732.54720.739365.435163@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <18732.54720.739365.435163@localhost.localdomain> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 26, 2008 at 10:21:12AM +0530, Sujith wrote: > Jouni Malinen wrote: > > + * @NL80211_ATTR_WIPHY_FREQ: frequency of the selected channel in MHz > > + * @NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET: included with NL80211_ATTR_WIPHY_FREQ > > + * if HT40 (40 MHz channels) are allowed: > > + * NL80211_SEC_CHAN_BELOW = secondary channel is below the primary channel > > + * NL80211_SEC_CHAN_ABOVE = secondary channel is above the primary channel > > The driver needs to know if the selected channel is HT or not. > It receives only HT20/HT40+/HT40- flags, but a HT/non-HT flag is required too. Yes, indeed. I added a new enum value for that: NL82011_SEC_CHAN_NO_HT = no HT (this is the default if NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET is not included) NL80211_SEC_CHAN_DISABLED = HT20 only NL80211_SEC_CHAN_BELOW = HT40- NL80211_SEC_CHAN_ABOVE = HT40+ The driver will then get hw.conf.ht.{enabled,sec_chan_offset} with the needed information. -- Jouni Malinen PGP id EFC895FA