Return-path: Received: from mail-gx0-f11.google.com ([209.85.217.11]:64641 "EHLO mail-gx0-f11.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbYKNVNM (ORCPT ); Fri, 14 Nov 2008 16:13:12 -0500 Received: by gxk4 with SMTP id 4so847955gxk.13 for ; Fri, 14 Nov 2008 13:13:10 -0800 (PST) Message-ID: <43e72e890811141313t33b6a3edo86488bea9a7b3371@mail.gmail.com> (sfid-20081114_221316_634791_C39CB2FC) Date: Fri, 14 Nov 2008 13:13:10 -0800 From: "Luis R. Rodriguez" To: "Bob Copeland" Subject: Re: Kernel oops when loading ath5k from compat-wireless in 2.6.27 Cc: "Dan McGee" , Sujith , linux-wireless@vger.kernel.org, "Michael Buesch" , "Johannes Berg" In-Reply-To: <43e72e890811141241k7ae83fc3qe90e2e42d61b8df6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <449c10960811132146s40aef6c6ue8dfeef5ba29812a@mail.gmail.com> <43e72e890811141006x1c396c78ube87a526f1435676@mail.gmail.com> <18717.49111.572993.44410@localhost.localdomain> <43e72e890811141029q24ad722fi6a7ae1e7dcd463bd@mail.gmail.com> <18717.50308.330801.765686@localhost.localdomain> <43e72e890811141037j5328f71fx7badb6f2b0e0831d@mail.gmail.com> <449c10960811141133o6d34c53fke3894a32cc1e5b8b@mail.gmail.com> <43e72e890811141241k7ae83fc3qe90e2e42d61b8df6@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Nov 14, 2008 at 12:41 PM, Luis R. Rodriguez wrote: > On Fri, Nov 14, 2008 at 12:33 PM, Bob Copeland wrote: >> On Fri, Nov 14, 2008 at 2:33 PM, Dan McGee wrote: >>> On Fri, Nov 14, 2008 at 12:37 PM, Luis R. Rodriguez wrote: >>>> On Fri, Nov 14, 2008 at 10:33 AM, Sujith wrote: >>>>> Luis R. Rodriguez wrote: >>>>>> > From the original log: >>>>>> > ath5k_pci 0000:01:00.0: registered as '' >>>>>> >>>>>> That comes from >>>>>> >>>>>> dev_info(&pdev->dev, "registered as '%s'\n", wiphy_name(hw->wiphy)); >>>>>> >>>>>> which means that may be buggy too as wiphy_name() gets >>>>>> >>>>>> return wiphy->dev.bus_id; >>>>>> >>>>>> and we only have set at that point wiphy->dev.parent IIRC. >>>>>> >>>>> >>>>> Nope, parent is set after that call in SET_IEEE80211_DEV() >>>>> phy[x] gets assigned in alloc_hw(). >>>>> >>>>> So why is it NULL even if alloc_hw() succeeds ? >>>> >>>> Parent is wiphy->dev.parent not wiphy->dev though >> >> Sujith is right, wiphy->dev.bus_id should be set by the time that's printed, >> since wiphy_new in alloc_hw fills it in. > > Ah, I see, yes, oh man. Well this is good :) OK then try the patch in the other thread. If that doesn't fix it then it has to be another issue. Luis