Return-path: Received: from mga11.intel.com ([192.55.52.93]:39882 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbYKXDdz (ORCPT ); Sun, 23 Nov 2008 22:33:55 -0500 Subject: Re: pull request: wireless-2.6 2008-11-18 From: Zhu Yi To: "John W. Linville" Cc: Tomas Winkler , "davem@davemloft.net" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sfr@canb.auug.org.au" In-Reply-To: <20081119143919.GA3485@tuxdriver.com> References: <20081119000719.GA19756@tuxdriver.com> <1ba2fa240811182246m17a6baf0ybde19af030a65819@mail.gmail.com> <1ba2fa240811190134u7974a840i532e8ed0e18f8c72@mail.gmail.com> <20081119143919.GA3485@tuxdriver.com> Content-Type: text/plain Date: Mon, 24 Nov 2008 11:34:15 +0800 Message-Id: <1227497655.2548.257.camel@debian.sh.intel.com> (sfid-20081124_043405_779859_BA4D194F) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2008-11-19 at 22:39 +0800, John W. Linville wrote: > Well, thanks for your opinion. Here is mine: I have to say something here. Although not related to the original ieee80211_notify_mac change. > The iwlwifi drivers have been hitting these problems for months, > and I have seen no effort by your team to address the problems. > It is possible that your team is working on them behind closed doors > and will eventually throw something over the wall to us. I'm tired > of waiting for that, and I imagine that hordes of iwlagn users are > tired of waiting as well. This is not correct. We are tracing this problem in our bugzilla. And it is the open place. Much more people have used it for a much longer time even before the kernel bugzilla existed. If you take a look at the bug, you know how much effort we put on it: http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1703 > Johannes has presented us with plausible fixes, and people are > reporting that the patches work for them. I can merge these patches, > or wait/hope/pray for some to come from your team. Experience > suggests > that if fixes do come from your team that they will either be buried > in some monster patch that largely addresses something else, or > that the patches will arrive with a changelog that is terse and/or > unintelligble. Subsequently, I am not optimistic about waiting. > > I think Johannes cited four different bugzilla.kernel.org entries > between those two patches. What is your team doing to address > those bugs? Johannes' effort is great and should certainly be praised. But looking down upon Intel's effort is nonsense. We suspected this alignment issue in the very beginning. But the set of users helped us to debug with this problem happened to have a different root cause than Johannes. Thus came with the alignment BUG_ON assert put into the code in case other people experience with it (unfortunately, it was a wrong one. As I had appologized for this already.) The problem should at least have two causes. Johannes had resolved one of them. The other one (AFAICS) relates to be in an 11n AP environment (no need to be associated with it) and takes longer time to reproduce. We will keep tracking it whatever we you think us about it. Thanks, -yi