Return-path: Received: from mail.atheros.com ([12.36.123.2]:10530 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752921AbYLVIWh (ORCPT ); Mon, 22 Dec 2008 03:22:37 -0500 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Mon, 22 Dec 2008 00:22:37 -0800 Date: Mon, 22 Dec 2008 13:40:50 +0530 From: Vasanthakumar Thiagarajan To: Johannes Berg CC: Vasanth Thiagarajan , "linux-wireless@vger.kernel.org" , Jouni Malinen , "linville@tuxdriver.com" Subject: Re: [PATCH] [RFC v2] mac80211: Scale down to non-HT association with TKIP/WEP as pairwise cipher Message-ID: <20081222081050.GA3500@localhost.localdomain> (sfid-20081222_092306_032800_9A5F4F79) References: <1229927497-30923-1-git-send-email-vasanth@atheros.com> <1229928585.3087.1.camel@johannes> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1229928585.3087.1.camel@johannes> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Dec 22, 2008 at 12:19:45PM +0530, Johannes Berg wrote: > > + case IW_AUTH_CIPHER_PAIRWISE: > > + if (sdata->vif.type == NL80211_IFTYPE_STATION) { > > + if (data->value & (IW_AUTH_CIPHER_WEP40 | > > + IW_AUTH_CIPHER_WEP104 | IW_AUTH_CIPHER_TKIP)) > > + sdata->u.sta.flags |= > > + IEEE80211_STA_TKIP_WEP_USED; > > + else > > + sdata->u.sta.flags &= > > + ~IEEE80211_STA_TKIP_WEP_USED; > > + } > > + break; > > Can't we check > the key algorithm for the pairwise key associated with the AP's sta_info > directly in _send_assoc? AP's sta_info will not have the negotiated pirwise cipher before association. Vasanth