Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:56871 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbZA0Vas (ORCPT ); Tue, 27 Jan 2009 16:30:48 -0500 Date: Tue, 27 Jan 2009 16:25:57 -0500 From: "John W. Linville" To: Alina Friedrichsen Cc: Bob Copeland , johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath5k: Set TSF fix Message-ID: <20090127212557.GC11849@tuxdriver.com> (sfid-20090127_223057_291196_488C184A) References: <20090124081223.50440@gmx.net> <1232901917.3837.0.camel@johannes.local> <20090126140130.14450@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20090126140130.14450@gmx.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 26, 2009 at 03:01:30PM +0100, Alina Friedrichsen wrote: > Hello! > > > > Either way, I think the changelog should back up the claim by > > > _something_. Even if it's just "tested on device XXX, old way doesn't > > > work, new way does" or "looked at legacy HAL code" or ... > > > > Agreed, "tested on..." would be good. I looked at the HAL and it > > doesn't have a set tsf function, only reset. > > The old code does not work on: > AR5418+AR2122 (ath9k) > AR5416+AR2133 (ath9k) > > The new code is tested on: > AR5418+AR2122 (ath9k) > AR5416+AR2133 (ath9k) > AR5001X+ (ath5k) > AR5007EG (ath5k) > > The old code was taken from: > https://dev.openwrt.org/browser/trunk/package/madwifi/patches/383-ibss_hostap.patch > (by Sven-Ola Tuecke) Could you resubmit this patch with some/all of the above information incorporated into the changelog? I'm dropping the current version (with limited changelog) just to avoid my own confusion. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.