Message-ID: <4963EBD0.2080907@gmail.com> (sfid-20090107_004005_041205_88AD479F)
Date: Tue, 06 Jan 2009 23:40:00 +0000
MIME-Version: 1.0
To: Andrey Borzenkov <arvidjaar@mail.ru>
CC: orinoco-devel@lists.sourceforge.net,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.28: warn_slowpath in orinoco receive path
References: <200901052005.12428.arvidjaar@mail.ru> <200901061251.41628.arvidjaar@mail.ru> <4963B8BE.9000204@gmail.com> <200901070007.52508.arvidjaar@mail.ru>
In-Reply-To: <200901070007.52508.arvidjaar@mail.ru>
Content-Type: text/plain; charset=ISO-8859-1
From: Dave <kilroyd@googlemail.com>
Sender: linux-wireless-owner@vger.kernel.org

Andrey Borzenkov wrote:
> On 06 January 2009 23:02:06 Dave wrote:
> 
>> Since we have to use spinlock we should introduce an rx_lock
>> specifically to protect the list so the tasklet is not held up by
>> anything else the driver is doing. I'll put something together if you
>> don't get round to it first.
>>
> 
> You mean something like attached patch? Not sure if it worth it frankly.

That's what I meant. I forgot we took orinoco_lock in orinoco_interrupt
though, and that highlights the fact that I've neglected to ensure
orinoco_lock is held when orinoco_rx is called from the tasklet.

So the locking gets simpler and fixes more problems than the one you
noticed. But there's some extra cleanup to do. I'll submit a patch in a
second.

I'm surprised my wireless hasn't misbehaved in the last year.


Dave.