Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:54335 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754038AbZBJQPx (ORCPT ); Tue, 10 Feb 2009 11:15:53 -0500 Date: Tue, 10 Feb 2009 11:04:51 -0500 From: "John W. Linville" To: Bryan Wu Cc: Dan Williams , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Cliff Cai Subject: Re: [PATCH] wireless: introduce POWEROF2_BLOCKSIZE_ONLY option Message-ID: <20090210160451.GD3534@tuxdriver.com> (sfid-20090210_171556_444876_697DC490) References: <1233819002-6912-1-git-send-email-cooloney@kernel.org> <1233846195.3028.14.camel@localhost> <386072610902052347m5754262bif18339809a00cb9f@mail.gmail.com> <386072610902060000s2e150e4cla19aca70f38b0474@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <386072610902060000s2e150e4cla19aca70f38b0474@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Feb 06, 2009 at 04:00:28PM +0800, Bryan Wu wrote: > On Fri, Feb 6, 2009 at 3:47 PM, Bryan Wu wrote: > > On Thu, Feb 5, 2009 at 11:03 PM, Dan Williams wrote: > >> On Thu, 2009-02-05 at 15:30 +0800, Bryan Wu wrote: > >>> From: Cliff Cai > >>> > >>> Introduce POWEROF2_BLOCKSIZE_ONLY option for those SD/SDIO host > >>> which only support transferring block with size of power-of-2 > >> > >> Is the point here to avoid copying in the controller code? As with the > >> other patches on libertas-dev, I really dislike adding code to *every > >> SDIO driver* just because the host has certain restrictions. I'd much > >> rather that the host/controller code became aware of it's own > >> restrictions, and exposed those generically to drivers above it. > >> Without a KConfig option. > >> > >> Seriously. The host knows what it needs. The code to handle that > >> should go in the host. > >> > > > > I agree here. > > > >> How about adding a method like "sdio_align_size" that takes the > >> controller's constraints into account? That seems a lot cleaner than > >> adding #define/KConfig junk to every SDIO driver in the kernel. One > >> less codepath to test, makes your life and all our lives easier. > >> > > > > So we plan to add method ".sdio_align_size" to SDIO stack. > > And Blackfin host driver will implement this method while others will > > implement this as a dummy function. > > > > sdio_align_size is already in SDIO stack, so we just need to add our > constraints to this function. I'm reading this as "this patch is unnecessary or will be replaced by something better", so I'm dropping it. If I misread that, feel free to repost...thanks! John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.