Return-path: Received: from mail.atheros.com ([12.36.123.2]:26872 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752886AbZBRWGS (ORCPT ); Wed, 18 Feb 2009 17:06:18 -0500 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Wed, 18 Feb 2009 14:06:18 -0800 Date: Wed, 18 Feb 2009 14:05:31 -0800 From: "Luis R. Rodriguez" To: Johannes Berg CC: Larry Finger , "Luis R. Rodriguez" , wireless Subject: Re: ieee80211_regdom module parameter for cfg80211 Message-ID: <20090218220531.GD4246@tesla> (sfid-20090218_230623_742799_FAEA64BD) References: <499C7DC0.4040608@lwfinger.net> <1234992712.4023.60.camel@johannes.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1234992712.4023.60.camel@johannes.local> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Feb 18, 2009 at 01:31:52PM -0800, Johannes Berg wrote: > On Wed, 2009-02-18 at 15:29 -0600, Larry Finger wrote: > > On at least one forum, I have seen the recommendation that a user set their > > regulatory domain by creating the file /etc/modprobe.d/cfg80211 with the > > contents "ieee80211_regdom=US". > > > > That works as long as CONFIG_WIRELESS_OLD_REGULATORY is set in their .config, > > but will fail if it is not. > > > > Should the module_param statement be moved outside the ifdef > > CONFIG_WIRELESS_OLD...? Setting the module parameter that way might not make any > > sense, but it surely shouldn't kill wireless. > > I actually see no reason to not just /honour/ it by calling crda with > its parameter if CONFIG_WIRELESS_OLD_REGULATORY isn't set. The idea was that things we want to get rid of will go in OLD_REG. Static regdoms for US, JP and EU fall into that and so does the module parameter. I believe it is silly to keep the module parameter around as we already have userspace APIs to let users set this. Luis