Return-path: Received: from yw-out-2324.google.com ([74.125.46.31]:61978 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbZBTER1 (ORCPT ); Thu, 19 Feb 2009 23:17:27 -0500 Received: by yw-out-2324.google.com with SMTP id 5so302267ywh.1 for ; Thu, 19 Feb 2009 20:17:26 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20090128121237.GB3197@sortiz.org> References: <760481.57662.qm@web57614.mail.re1.yahoo.com> <20090126114453.GB3197@sortiz.org> <20090127162437.GA3596@sortiz.org> <1ba2fa240901272312j270eedb5x33534a9703d26e06@mail.gmail.com> <20090128113751.GA3197@sortiz.org> <1ba2fa240901280352o56ccbc07h50c7a4bfcd0ac9ab@mail.gmail.com> <20090128121237.GB3197@sortiz.org> Date: Thu, 19 Feb 2009 23:17:25 -0500 Message-ID: (sfid-20090220_051738_142036_6D947AB4) Subject: Re: kernel BUG at drivers/net/wireless/iwlwifi/iwl3945-base.c:3127! From: Jason Andryuk To: Samuel Ortiz Cc: Tomas Winkler , reinette chatre , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jan 28, 2009 at 7:12 AM, Samuel Ortiz wrote: > On Wed, Jan 28, 2009 at 01:52:17PM +0200, Tomas Winkler wrote: >> On Wed, Jan 28, 2009 at 1:37 PM, Samuel Ortiz wrote: >> > On Wed, Jan 28, 2009 at 09:12:48AM +0200, Tomas Winkler wrote: >> >> On Wed, Jan 28, 2009 at 1:31 AM, Jason Andryuk wrote: >> >> >> No, that's just a consequence of the bug, not the bug itself. >> >> >> Would you mind applying this patch on top of your latest wireless-testing tree >> >> >> and testing 3945 with it ? Thanks for your patience. >> >> > >> >> > The patch did not cleanly apply, but I just removed the lines >> >> > indicated in the patch. It crashed with a NULL pointer dereference. >> >> >> >> Samuel >> >> It was really wrong try, you cannot just leave place where firmware >> >> updated read pointer unallocated. I would rather focus on differences >> >> introduced by this patch. >> > Well, that's what I did. I neglected to check if rb_stts were actually used. >> > >> > >> >> commit 738910c064ff461051cd37e17199f270ff88a9a3 iwl3945: use rx queue >> >> management infrastructure from iwlcore is the first to trigger the >> >> BUG_ON. However, prior versions would dereference a NULL pointer >> >> before the driver could get far enough to trigger the BUG_ON. >> > I know, that's what Jason described. >> > I think I now understand why. Prior to >> > 738910c064ff461051cd37e17199f270ff88a9a3, you introduced >> > c2a0aa3cb733452e749727680e380dca6cc10a68 without actually allocating the >> > rb_stts pointer, which was really wrong too. >> >> Yes I made mistake then I tought that 3945 take also init path of agn >> already... Now it's hard to besect :(. >> I suspect the rx queue managment infrastructure more because we brohgt >> iwlagn bug into 3945 I guess it wrong rx buffer index handling. It's >> really important we nail it now this will solve also our troubles in >> iwlagn, where it get lost upon tons of patches. > I agree. I also suspect that a lot more people will report the same problem > when this code leaves wireless-testing for upstream inclusion. I tried out wireless-testing as of 2009-02-18. I was excited initially because I was able to connect to my AP and ping and access the internet. I started writing an email over the connection, but then things went sour. Logs showed a Microcode SW error, but that comes after successful authentication to the AP. [ 323.904100] iwl3945 0000:03:00.0: Microcode SW error detected. Restarting 0x82000008. [ 323.904119] iwl3945 0000:03:00.0: Error Reply type 0x00000005 cmd UNKNOWN (0x00) seq 0x013A ser 0x004E0000 I think it was still working, but it then stopped and I discovered a second Microcode SW error. [ 713.561161] iwl3945 0000:03:00.0: Microcode SW error detected. Restarting 0x82000008. [ 713.561172] iwl3945 0000:03:00.0: Error Reply type 0x00000005 cmd UNKNOWN (0x40) seq 0x013A ser 0x004E0000 Debugging was not turned on, so I don't have further information. When I rebooted, iwl3945 failed to find the AP and hence did not connect. Jason