Return-path: Received: from mail.deathmatch.net ([70.167.247.36]:1402 "EHLO mail.deathmatch.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbZBGFEQ (ORCPT ); Sat, 7 Feb 2009 00:04:16 -0500 Date: Sat, 7 Feb 2009 00:03:56 -0500 From: Bob Copeland To: Nick Kossifidis Cc: Nick Kossifidis , ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com, nbd@openwrt.org Subject: Re: [PATCH 5/5] ath5k: Update reset code Message-ID: <20090207050356.GA16457@hash.localnet> (sfid-20090207_060429_786118_74BC81EF) References: <20090131023147.GE3342@makis> <20090204215706.GA5651@makis> <20090205154532.M30551@bobcopeland.com> <40f31dec0902051306m769712ecn858672ba24524c63@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <40f31dec0902051306m769712ecn858672ba24524c63@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Feb 05, 2009 at 11:06:59PM +0200, Nick Kossifidis wrote: > I think this is because we call reset too many times. Try removing > call to reset from config_interface, after some tests i did it seems > wrong (we don't need to reset pcu and if we do, we don't need to reset > the whole chip and re run phy initialization etc). I don't get any > problems with ar2425 but i didn't get any before anyway (i never got a > hang, just a few bmiss interrupts, not a storm). Yep, with BMISS interrupts turned off and config_interface no longer calling reset, it's quite stable now. Maybe there was some timing thing at play. If we add a patch to remove those then I'm satisfied :) -- Bob Copeland %% www.bobcopeland.com