Return-path: Received: from mail.deathmatch.net ([70.167.247.36]:2817 "EHLO mail.deathmatch.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbZCCNDL (ORCPT ); Tue, 3 Mar 2009 08:03:11 -0500 Date: Tue, 3 Mar 2009 08:02:44 -0500 From: Bob Copeland To: Nick Kossifidis Cc: Pavel Roskin , "Luis R. Rodriguez" , Jiri Slaby , "ath5k-devel@venema.h4ckr.net" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "John W. Linville" Subject: Re: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition Message-ID: <20090303130244.GA4901@hash.localnet> (sfid-20090303_140315_804980_48F0F154) References: <20090226230338.M86894@bobcopeland.com> <49A7236E.2020807@gmail.com> <49A726A7.6090809@gmail.com> <20090227022704.GA29850@hash.localnet> <20090227023912.GF13456@tesla> <20090227030608.GA29974@hash.localnet> <1235884912.9224.26.camel@mj> <20090303034600.GA3757@hash.localnet> <40f31dec0903022031l20ecc3dcx9ba7859cb24fa5ae@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <40f31dec0903022031l20ecc3dcx9ba7859cb24fa5ae@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Mar 03, 2009 at 06:31:05AM +0200, Nick Kossifidis wrote: > > According to docs the rate field is only valid if more flag is clear > (we have the last descriptor) and only if the receive ok flag is set > or both receive ok and phy error flags are cleared. We never do such > checks so we might actually try to process this field when we already > know we shouldn't... Well, we do skip rs_more packets without getting the rate, hopefully phy error packets too. The warning would definitely show if we have any bugs there. > Also the following rate codes are reserved (except XR codes that we > already know): [snip] > and i don't believe i've ever seen them, so we can warn on them too > and print something like "Reserved rate code: %x", also it would be > nice to warn on XR rates (1,2,3,6,7) in case we want to debug this in > the future. Good idea, though I'm somewhat of the mind that we should let the current patch go in for a bit and see if any of these pop up. But that's because I'm lazy :) -- Bob Copeland %% www.bobcopeland.com