Return-path: Received: from mail.deathmatch.net ([70.167.247.36]:3738 "EHLO mail.deathmatch.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754604AbZCGMfA (ORCPT ); Sat, 7 Mar 2009 07:35:00 -0500 Date: Sat, 7 Mar 2009 07:34:38 -0500 From: Bob Copeland To: Jiri Slaby Cc: "John W. Linville" , linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" Subject: Re: [PATCH 2/2] ath5k: don't change mac in eeprom_read_mac on error Message-ID: <20090307123438.GA13756@hash.localnet> (sfid-20090307_133506_012919_FB35BA47) References: <1236418002-2189-1-git-send-email-jirislaby@gmail.com> <1236418002-2189-2-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1236418002-2189-2-git-send-email-jirislaby@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Mar 07, 2009 at 10:26:42AM +0100, Jiri Slaby wrote: > Do not touch mac parameter passed to ath5k_eeprom_read_mac unless > we are sure we have correct address. I.e. when returning error, do > not change it. > > While at it, use '= {}' compiler trick for memsetting mac_d. > > Signed-off-by: Jiri Slaby > Cc: Nick Kossifidis Wrong email address for Nick :) Otherwise, Acked-by: Bob Copeland -- Bob Copeland %% www.bobcopeland.com