Return-path: Received: from smtp.nokia.com ([192.100.105.134]:39030 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754830AbZCOUM4 (ORCPT ); Sun, 15 Mar 2009 16:12:56 -0400 Message-ID: <49BD611F.9010100@nokia.com> (sfid-20090315_211258_442417_3C3D2954) Date: Sun, 15 Mar 2009 22:12:15 +0200 From: Kalle Valo MIME-Version: 1.0 To: Johannes Berg CC: "John W. Linville" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] mac80211: don't drop null frames during software scan References: <20090314144405.670.16447.stgit@tikku> <1237043931.5235.67.camel@johannes.local> <49BBCE18.4090606@nokia.com> <1237046839.5235.86.camel@johannes.local> (sfid-20090314_170734_362051_D492D2DA) <1237046957.5235.88.camel@johannes.local> In-Reply-To: <1237046957.5235.88.camel@johannes.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg wrote: > On Sat, 2009-03-14 at 17:07 +0100, Johannes Berg wrote: >> On Sat, 2009-03-14 at 17:32 +0200, Kalle Valo wrote: >> >>> Perhaps. I chose this path only because it was simple to implement :) >>> I'll take a look at the scan code in more detail and fix it there. >> You're kinda right too, we want to disable the queues first, then set >> sw_scanning/notify the driver, and then send the nullfunc, I think. So >> it's either this patch, or iterating the interface list twice. > > Similarly for the beacon disable part, that _needs_ to be done after > sw_scanning=true otherwise it won't actually work... > > I think I prefer your patch over that complexity, but would like to have > a good comment explaining it, and possibly one in > scan.c:ieee80211_start_scan that points to that code. I just sent v2. If you have time, please take a look and comment. Kalle