Return-path: Received: from mga02.intel.com ([134.134.136.20]:39366 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbZC0QZ3 (ORCPT ); Fri, 27 Mar 2009 12:25:29 -0400 Subject: Re: [PATCH 2/3] iwlwifi: remove STATUS_ALIVE checking from rf_kill From: reinette chatre To: Helmut Schaa , "linville@tuxdriver.com" Cc: "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" , "Guy, Wey-Yi W" In-Reply-To: <1238169818.25568.8.camel@rc-desk> References: <1238087650-26993-1-git-send-email-reinette.chatre@intel.com> <1238087650-26993-2-git-send-email-reinette.chatre@intel.com> <1238087650-26993-3-git-send-email-reinette.chatre@intel.com> <200903270718.18593.helmut.schaa@gmail.com> <1238169818.25568.8.camel@rc-desk> Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Mar 2009 09:30:56 -0700 Message-Id: <1238171456.25568.23.camel@rc-desk> (sfid-20090327_172532_201705_6E74C36C) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi John, On Fri, 2009-03-27 at 09:03 -0700, reinette chatre wrote: > On Thu, 2009-03-26 at 23:18 -0700, Helmut Schaa wrote: > > Hi again, > >=20 > > Am Donnerstag, 26. M=C3=A4rz 2009 schrieb Reinette Chatre: > > > Remove STATUS_ALIVE checking when HW RF KILL disabled, the bit ge= t > > > clear in __iwl_down() function; the additional checking will fail= and > > > cause RF can not be turn back on. > >=20 > > Maybe just checking for is_open instead of STATUS_ALIVE will fix th= e issue > > too? I only had a quick look but it looks possible. AFAICS is_open = indicates > > if the interface was taken up by mac80211. So if the interface is u= p but > > STATUS_ALIVE is not set we want to restart the adapter after unkill= ing but > > if the interface is still down (is_open=3D=3D0) we do not want to r= estart the > > adapter. Furthermore, is_open is also set in case the interface was= taken > > up but wireless was rfkilled. >=20 > Very good idea ... I'm looking into this. Could you please drop this patch? We will send a new fix for this problem using Helmut's suggestion. Thank you Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html