Return-path: Received: from fmailhost03.isp.att.net ([204.127.217.103]:54978 "EHLO fmailhost03.isp.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934547AbZDIOqz (ORCPT ); Thu, 9 Apr 2009 10:46:55 -0400 Message-ID: <49DE0A4D.7010408@lwfinger.net> (sfid-20090409_164706_775311_A1831C21) Date: Thu, 09 Apr 2009 09:46:37 -0500 From: Larry Finger MIME-Version: 1.0 To: Kalle Valo CC: Johannes Berg , reinette.chatre@intel.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] fix iwl3945 registration regression References: <87ljqamktq.fsf@litku.valot.fi> <1239263762.32594.19.camel@johannes.local> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo wrote: > On Thu, Apr 9, 2009 at 10:56 AM, Johannes Berg > wrote: >> I forgot that iwl3945 registration is separate from iwlagn. >> >> Signed-off-by: Johannes Berg > > Thanks, this fixed the problem for me. > > Tested-by: Kalle Valo > > Although I wasn't able to get iwl3945 working yet: > > Apr 9 17:06:57 tikku kernel: [ 16.586612] iwl3945: Intel(R) > PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.2.26kd > Apr 9 17:06:57 tikku kernel: [ 16.591406] iwl3945: Copyright(c) > 2003-2009 Intel Corporation > Apr 9 17:06:57 tikku kernel: [ 16.596203] iwl3945 0000:03:00.0: PCI > INT A -> GSI 17 (level, low) -> IRQ 17 > Apr 9 17:06:57 tikku kernel: [ 16.600996] iwl3945 0000:03:00.0: > setting latency timer to 64 > Apr 9 17:06:57 tikku kernel: [ 16.660038] iwl3945 0000:03:00.0: > Tunable channels: 13 802.11bg, 23 802.11a channels > Apr 9 17:06:57 tikku kernel: [ 16.664799] iwl3945 0000:03:00.0: > Detected Intel Wireless WiFi Link 3945ABG > Apr 9 17:06:57 tikku kernel: [ 16.669786] iwl3945 0000:03:00.0: irq > 29 for MSI/MSI-X > Apr 9 17:06:57 tikku kernel: [ 16.675157] phy0: Selected rate > control algorithm 'iwl-3945-rs' > Apr 9 17:06:57 tikku kernel: [ 16.681674] phy0: Failed to initialize wep: -2 > Apr 9 17:06:57 tikku kernel: [ 16.695543] iwl3945 0000:03:00.0: > Failed to register hw (error -2) > Apr 9 17:06:57 tikku kernel: [ 16.700576] iwl3945 0000:03:00.0: PCI > INT A disabled > Apr 9 17:06:57 tikku kernel: [ 16.705359] iwl3945: probe of > 0000:03:00.0 failed with error -2 > > Maybe this is the infamous module loading bug I see people talking > about? I'll investigate it later. Yes it is. The key is the "Failed to initialize wep", which is caused by a failure to load modules ecb and arc4. Apply that patch and all will be well. Larry