Return-path: Received: from kroah.org ([198.145.64.141]:44881 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751644AbZDSWfD (ORCPT ); Sun, 19 Apr 2009 18:35:03 -0400 Date: Sun, 19 Apr 2009 15:32:18 -0700 From: Greg KH To: Forest Bond Cc: Larry Finger , "John W. Linville" , Johannes Berg , Marcel Holtmann , linux-wireless@vger.kernel.org, Dan Williams Subject: Re: [PATCH] Add vt6656 driver to drivers/staging. Message-ID: <20090419223218.GA30599@kroah.com> (sfid-20090420_003509_111501_63FACF1A) References: <1239709727.4778.6.camel@johannes.local> <1239712106.11795.21.camel@violet> <1239713034.17109.10.camel@johannes.local> <20090414130248.GA3291@tuxdriver.com> <20090414141852.GB20470@storm.local.network> <20090415011020.GC10045@kroah.com> <20090415015116.GJ20470@storm.local.network> <20090419170950.GA28885@storm.local.network> <49EB8119.1020402@lwfinger.net> <20090419200146.GB28885@storm.local.network> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20090419200146.GB28885@storm.local.network> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Apr 19, 2009 at 04:01:46PM -0400, Forest Bond wrote: > Hi Larry, > > On Sun, Apr 19, 2009 at 02:52:57PM -0500, Larry Finger wrote: > > Forest Bond wrote: > > > > > > However, I did have a question: > > > > > > The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. > > > Should the directories be named "viawget" and "vntwusb," respectively, or is it > > > appropriate for them to be named "vt6655" and "vt6656"? > > > > Of course Greg has the final say, but I vote to keep the directories with the > > vt6656 name and change the name of the driver, which is defined in the line > > #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver. > > This makes sense to me. I'll proceed this way for now. Greg, let me know if > you'd prefer I didn't do this. No objection from me. thanks, greg k-h