Return-path: Received: from mga11.intel.com ([192.55.52.93]:55496 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754688AbZD3S1I (ORCPT ); Thu, 30 Apr 2009 14:27:08 -0400 Subject: Re: iwlwifi: remove EXPORT_SYMBOL for static symbol From: reinette chatre To: Andreas Schwab Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: References: <1241112119.10498.11.camel@rc-desk> Content-Type: text/plain Date: Thu, 30 Apr 2009 11:33:10 -0700 Message-Id: <1241116390.10498.50.camel@rc-desk> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Andreas, On Thu, 2009-04-30 at 10:27 -0700, Andreas Schwab wrote: > > reinette chatre > writes: > > > On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote: > >> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes > >> this build error: > >> > >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict > >> > >> Signed-off-by: Andreas Schwab > >> --- > >> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was > > > >>From which repo is this commit id? > > That's from davem/net-2.6 or linville/wireless-2.6.git Thanks. Even though this patch obsoletes 6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have that patch in the repo as it removes another unnecessary EXPORT_SYMBOL. I would thus prefer that both patches are included. Reinette