Subject: Re: [PATCH] iwlwifi: make iwl_set_rate static
From: reinette chatre <reinette.chatre@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
In-Reply-To: <1241772804.1567.29.camel@johannes.local>
References: <1241772804.1567.29.camel@johannes.local>
Content-Type: text/plain
Date: Fri, 08 May 2009 10:32:01 -0700
Message-Id: <1241803921.6198.459.camel@rc-desk>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

Hi Johannes,

On Fri, 2009-05-08 at 01:53 -0700, Johannes Berg wrote:
> It's not needed elsewhere.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>  drivers/net/wireless/iwlwifi/iwl-core.c |    2 +-
>  drivers/net/wireless/iwlwifi/iwl-core.h |    2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h	2009-05-08 10:52:20.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h	2009-05-08 10:52:24.000000000 +0200
> @@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl
>  
>  u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv);
>  
> -void iwl_set_rate(struct iwl_priv *priv);
> -
>  u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx);
>  
>  static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c	2009-05-08 10:52:20.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c	2009-05-08 10:52:24.000000000 +0200
> @@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc
>  }
>  EXPORT_SYMBOL(iwl_connection_init_rx_config);
>  
> -void iwl_set_rate(struct iwl_priv *priv)
> +static void iwl_set_rate(struct iwl_priv *priv)
>  {
>  	const struct ieee80211_supported_band *hw = NULL;
>  	struct ieee80211_rate *rate;
> 
> 

To make this complete, could you please also remove the EXPORT_SYMBOL of
this function and also its declaration in iwl-core.h?

Thank you

Reinette