Return-path: Received: from mga02.intel.com ([134.134.136.20]:1250 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755489AbZEHRl3 (ORCPT ); Fri, 8 May 2009 13:41:29 -0400 Subject: Re: [PATCH v2] iwlwifi: make iwl_set_rate static From: reinette chatre To: Johannes Berg Cc: John Linville , linux-wireless In-Reply-To: <1241803902.4495.28.camel@johannes.local> References: <1241772804.1567.29.camel@johannes.local> <1241803902.4495.28.camel@johannes.local> Content-Type: text/plain Date: Fri, 08 May 2009 10:47:50 -0700 Message-Id: <1241804870.6198.471.camel@rc-desk> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2009-05-08 at 10:31 -0700, Johannes Berg wrote: > It's not needed outside iwl-core.c > > Signed-off-by: Johannes Berg > --- > drivers/net/wireless/iwlwifi/iwl-core.c | 3 +-- > drivers/net/wireless/iwlwifi/iwl-core.h | 2 -- > 2 files changed, 1 insertion(+), 4 deletions(-) > > --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:53:34.000000000 +0200 > +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 19:30:16.000000000 +0200 > @@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl > > u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv); > > -void iwl_set_rate(struct iwl_priv *priv); > - > u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx); > > static inline u32 iwl_ant_idx_to_flags(u8 ant_idx) > --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 13:48:01.000000000 +0200 > +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 19:30:21.000000000 +0200 > @@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc > } > EXPORT_SYMBOL(iwl_connection_init_rx_config); > > -void iwl_set_rate(struct iwl_priv *priv) > +static void iwl_set_rate(struct iwl_priv *priv) > { > const struct ieee80211_supported_band *hw = NULL; > struct ieee80211_rate *rate; > @@ -1170,7 +1170,6 @@ void iwl_set_rate(struct iwl_priv *priv) > priv->staging_rxon.ofdm_basic_rates = > (IWL_OFDM_BASIC_RATES_MASK >> IWL_FIRST_OFDM_RATE) & 0xFF; > } > -EXPORT_SYMBOL(iwl_set_rate); > > void iwl_rx_csa(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb) > { > > Thank you Acked-by: Reinette Chatre Reinette