Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:23293 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbZFUI32 (ORCPT ); Sun, 21 Jun 2009 04:29:28 -0400 Date: Sun, 21 Jun 2009 12:29:21 +0400 From: Dmitry Eremin-Solenikov To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, davem@davemloft.net, Stephen Rothwell , Sergey Lapin , Darren Salt Subject: Re: [PATCH 1/6] crc-itu-t: add bit-reversed calculation Message-ID: <20090621082921.GA12749@doriath.ww600.siemens.net> References: <1244021629-18409-1-git-send-email-dbaryshkov@gmail.com> <1244021629-18409-2-git-send-email-dbaryshkov@gmail.com> <1244033004.21215.4.camel@deadeye> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1244033004.21215.4.camel@deadeye> Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On Wed, Jun 03, 2009 at 01:43:24PM +0100, Ben Hutchings wrote: > On Wed, 2009-06-03 at 13:33 +0400, Dmitry Eremin-Solenikov wrote: > [...] > > +/** > > + * crc_itu_t_bitreversed - Compute the CRC-ITU-T for the data buffer; > > + * the buffer content is assumed to be bit-reversed > [...] > > This short description spills onto two lines which is invalid and breaks > the generation of docs. Sorry to point this out after recommending the > patch to you. > > I've changed the description to "crc_itu_t_bitreversed - Compute the > CRC-ITU-T for a bit-reversed data buffer" all on one line. Just another not w.r.t. this patch: one should add 'select BITREVERSE' to this Kconfig entry, as it depends on bitreversing stuff. -- With best wishes Dmitry