Return-path: Received: from mail-fx0-f213.google.com ([209.85.220.213]:58347 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbZFDOKm convert rfc822-to-8bit (ORCPT ); Thu, 4 Jun 2009 10:10:42 -0400 MIME-Version: 1.0 In-Reply-To: <20090604134455.GB2839@tuxdriver.com> References: <1243868091-5315-1-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-2-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-3-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-4-git-send-email-dbaryshkov@gmail.com> <20090603173214.6d3997f7.akpm@linux-foundation.org> <20090604111634.GA28064@doriath.ww600.siemens.net> <20090604134455.GB2839@tuxdriver.com> Date: Thu, 4 Jun 2009 18:10:41 +0400 Message-ID: Subject: Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation From: Dmitry Eremin-Solenikov To: "John W. Linville" Cc: Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, slapin@ossfans.org, maxim.osipov@siemens.com, dmitry.baryshkov@siemens.com, oliver.fendt@siemens.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/6/4 John W. Linville : > On Thu, Jun 04, 2009 at 03:16:34PM +0400, Dmitry Eremin-Solenikov wrote: >> On Wed, Jun 03, 2009 at 05:32:14PM -0700, Andrew Morton wrote: >> > On Mon, ?1 Jun 2009 18:54:44 +0400 >> > Dmitry Eremin-Solenikov wrote: > >> > > + switch (addr->addr_type) { >> > > + case IEEE802154_ADDR_LONG: >> > > + ? ? ? ? rtnl_lock(); >> > > + ? ? ? ? dev = dev_getbyhwaddr(net, ARPHRD_IEEE802154, addr->hwaddr); >> > > + ? ? ? ? if (dev) >> > > + ? ? ? ? ? ? ? ? dev_hold(dev); >> > > + ? ? ? ? rtnl_unlock(); >> > > + ? ? ? ? break; >> > > + case IEEE802154_ADDR_SHORT: >> > > + ? ? ? ? if (addr->pan_id != 0xffff && addr->short_addr != IEEE802154_ADDR_UNDEF && addr->short_addr != 0xffff) { >> > > + ? ? ? ? ? ? ? ? struct net_device *tmp; >> > > + >> > > + ? ? ? ? ? ? ? ? rtnl_lock(); >> > > + >> > > + ? ? ? ? ? ? ? ? for_each_netdev(net, tmp) { >> > > + ? ? ? ? ? ? ? ? ? ? ? ? if (tmp->type == ARPHRD_IEEE802154) { >> > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (IEEE802154_MLME_OPS(tmp)->get_pan_id(tmp) == addr->pan_id >> > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? && IEEE802154_MLME_OPS(tmp)->get_short_addr(tmp) == addr->short_addr) { >> > >> > You must use very wide xterms :( >> >> ~120 chars in width :) ?We prefer to have a single code line split between >> several screen lines, rather than split it manually in some weird places >> just to justify width of 80 chars. > > Hopefully you realize that many find this difficult to read -- I just > can't spread my eyes far enough to comprehend the lines. > > 80 chars is not a hard limit, but it is a good goal. ?120 is too wide. We do try to fit the lines into 80 chars, but when that seems logical. I strongly dislike breaking comparations between lines. -- With best wishes Dmitry