Return-path: Received: from mga09.intel.com ([134.134.136.24]:8108 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbZFKUnD (ORCPT ); Thu, 11 Jun 2009 16:43:03 -0400 Subject: Re: [ath9k-devel] [PATCH] mac80211: disassociate when switching bands and not scanning From: reinette chatre To: "Luis R. Rodriguez" Cc: Johannes Berg , Kalle Valo , "Zhu, Yi" , "j@w1.fi" , "linux-wireless@vger.kernel.org" , "linville@tuxdriver.com" , "ipw3945-devel@lists.sourceforge.net" , "Abbas, Mohamed" , "ath9k-devel@lists.ath9k.org" In-Reply-To: <43e72e890906111204g18e71720w97cb2ea346e5d663@mail.gmail.com> References: <1244666131-20031-1-git-send-email-lrodriguez@atheros.com> <1244666973.20900.399.camel@rc-desk> <43e72e890906101349t502e9022h16fa79ea512f8b4d@mail.gmail.com> <1244667817.20900.402.camel@rc-desk> <43e72e890906101404l6a8bee67r560f7c8a1c5f8c36@mail.gmail.com> <1244668077.4706.4.camel@johannes.local> <43e72e890906101542l5064384auf027267a3d19f3ee@mail.gmail.com> <43e72e890906101544i22bacc8fxa0a7d045eea50280@mail.gmail.com> <43e72e890906111204g18e71720w97cb2ea346e5d663@mail.gmail.com> Content-Type: text/plain Date: Thu, 11 Jun 2009 13:50:07 -0700 Message-Id: <1244753407.20900.456.camel@rc-desk> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Luis, On Thu, 2009-06-11 at 12:04 -0700, Luis R. Rodriguez wrote: > On Wed, Jun 10, 2009 at 3:44 PM, Luis R. > Rodriguez wrote: > > On Wed, Jun 10, 2009 at 3:42 PM, Luis R. > > Rodriguez wrote: > >> On Wed, Jun 10, 2009 at 2:07 PM, Johannes Berg wrote: > >>> On Wed, 2009-06-10 at 14:04 -0700, Luis R. Rodriguez wrote: > >>>> On Wed, Jun 10, 2009 at 2:03 PM, reinette > >>>> chatre wrote: > >>>> > >>>> >> > This touches code targeted for removal in recent "mac80211: disconnect > >>>> >> > when user changes channel" patch. > >>>> >> > >>>> >> Heh I don't see that patch yet but if it exists that should fix this > >>>> >> too unless that patch didn't deauth/disassoc. Did you try with it > >>>> >> applied by any chance? I can't seem to find that patch on the list. > >>>> > > >>>> > That patch does seem to have same intention as yours. It is still RFC so > >>>> > I am not sure about its status. I did not test with it, but will do so. > >>>> > The patch can be found at > >>>> > http://marc.info/?l=linux-wireless&m=124458448631186&w=2 > >>>> > >>>> Thanks yes, I see, yup I think that should fix it, we need a fix for > >>>> stable though. Not sure how John or Johannes want to handle this. > >>> > >>> *scratches head* > >>> are you advocating those rate cleanups for stable? > >> > >> No, a few fixes are needed for stable (now 2.6.30) though. For example > >> the assert downgrade patch can be used but most likely that'll just be > >> doing something completely wrong, so we do need to ensure the dynamic > >> ps stuff does not trigger when scanning and I do consider that a > >> proper fix for stable. I forget when ps stuff when in. > >> > >> The issue here is this *is* a bug not only for iwlwifi. iwlwifi > >> currently gets no warning because of a work around in the driver's > >> rate control algorithm as it is in stable. I haven't tried running > >> this band change with ath9k > > > > Just to clarify -- I did run this with the patches I posted and I did > > hit the warning, but I did not try this without the patches I posted. > > Chances that will cause the kernel to commit suicide and oops. > > As expected I was able to reproduce the warning with atht5k and ath9k > on 2.6.30. I did not get a crash with ath9k though, which is good. But > the warning is still present. > > Do we want to fix this for stable? If so is the patch I posted reasonable? I ran the steps to reproduce on a kernel that is the latest wireless-testing + "mac80211: disconnect when user changes channel" + "iwlwifi: remove rs_get_rate workaround". Unfortunately I still get the rs_get_rate warning. Reinette