Return-path: Received: from mail.atheros.com ([12.36.123.2]:49008 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbZFKGxf (ORCPT ); Thu, 11 Jun 2009 02:53:35 -0400 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Wed, 10 Jun 2009 23:53:38 -0700 Date: Thu, 11 Jun 2009 12:22:03 +0530 From: Vasanthakumar Thiagarajan To: Johannes Berg CC: Vasanth Thiagarajan , "linux-wireless@vger.kernel.org" , Luis Rodriguez Subject: Re: [RFT 2/3] ath9k: port to cfg80211 rfkill Message-ID: <20090611065203.GC10126@vasanth-laptop> References: <20090602111027.460530075@sipsolutions.net> <20090602111112.191915040@sipsolutions.net> <20090610132015.GA10126@vasanth-laptop> <1244644712.26814.6.camel@johannes.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1244644712.26814.6.camel@johannes.local> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 10, 2009 at 08:08:32PM +0530, Johannes Berg wrote: > > Thanks, will fix, this doesn't seem to be ath9k specific. It's the > dreaded locking in rfkill. I can work around it easily in cfg80211, or > fix rfkill, will see what's easier. Thanks. > > > One more issue is, when rfkill is enabled before > > reboot, I could not bring up the interface when the rfkill is turned > > off after reboot. > > Sounds like the driver doesn't initialise properly. I dont think this one is driver specific as this happens only when module is loaded at boot time. I works fine after ath9k is reloaded. > need to move ath_start_rfkill_poll() to ath_attach(), could you please > try that? We do hw reset during radio enable/disable, this needs current channel to be configured but i'm not sure if we need to do all these during attach time. Thanks, Vasanth