Return-path: Received: from ey-out-2122.google.com ([74.125.78.25]:47456 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbZGaS1w convert rfc822-to-8bit (ORCPT ); Fri, 31 Jul 2009 14:27:52 -0400 Received: by ey-out-2122.google.com with SMTP id 9so612821eyd.37 for ; Fri, 31 Jul 2009 11:27:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <43e72e890907311120r76d3db6et91128ccbc3a90c63@mail.gmail.com> References: <20090731180238.GA7963@makis> <43e72e890907311111k10cce08et84510866c68e0297@mail.gmail.com> <40f31dec0907311118o5460952xd3462b14375eeb72@mail.gmail.com> <43e72e890907311120r76d3db6et91128ccbc3a90c63@mail.gmail.com> Date: Fri, 31 Jul 2009 21:27:51 +0300 Message-ID: <40f31dec0907311127o4bc4de73u1b4b5dfeb66d55b9@mail.gmail.com> Subject: Re: [PATCH 1/4]: Check EEPROM before tweaking SERDES From: Nick Kossifidis To: "Luis R. Rodriguez" Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com, jirislaby@gmail.com, me@bobcopeland.com, nbd@openwrt.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/7/31 Luis R. Rodriguez : > On Fri, Jul 31, 2009 at 11:18 AM, Nick Kossifidis wrote: >> 2009/7/31 Luis R. Rodriguez : >>> >>> Can the changes for the code be done before the move, or after so that >>> way the actual code changes to the section can be easily readable? >>> >> >> Since we use EEPROM infos we must move this after eeprom initialization. > > Yes, but my point is a move can be done in one patch, changes to that > code in a separate patch, to help understand what is going on during > patch review. > >  Luis > I think this will pollute the logs, it's a very simple change and commented. -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick