Return-path: Received: from mail-ew0-f226.google.com ([209.85.219.226]:38697 "EHLO mail-ew0-f226.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbZGKPXe convert rfc822-to-8bit (ORCPT ); Sat, 11 Jul 2009 11:23:34 -0400 Received: by ewy26 with SMTP id 26so1718759ewy.37 for ; Sat, 11 Jul 2009 08:23:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <43e72e890907101102i29352c6bq9e511663e2c3a986@mail.gmail.com> References: <20090709211221.GA4854@steven676.net> <43e72e890907101102i29352c6bq9e511663e2c3a986@mail.gmail.com> Date: Sat, 11 Jul 2009 18:23:32 +0300 Message-ID: <40f31dec0907110823j2f4aafffs81882757d03353be@mail.gmail.com> Subject: Re: [ath9k-devel] [PATCH] ath9k: Fix enabling OFDM weak signal detection From: Nick Kossifidis To: "Luis R. Rodriguez" Cc: Steven Luo , Bennyam Malavazi , "John W. Linville" , linux-wireless@vger.kernel.org, Jouni Malinen , Senthil Balasubramanian , ath9k-devel@lists.ath9k.org, Vasanthakumar Thiagarajan Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/7/10 Luis R. Rodriguez : > On Thu, Jul 9, 2009 at 2:12 PM, Steven Luo wrote: >> From: Steven Luo >> >> It seems that OFDM weak signal detection should be enabled after an ANI >> state reset, as indicated by the initial setting of ofdmWeakSigDetectOff >> and what the open Atheros HAL does.  Unfortunately, the reversed sense >> of ofdmWeakSigDetectOff (true if weak signal detection is NOT enabled) >> seems to have resulted in a mixup here, causing weak signal detection to >> be disabled. >> >> This patch significantly improves reception and throughput from distant >> stations for my AR5416-based AP running compat-wireless 2009-06-25. >> >> Signed-off-by: Steven Luo >> Cc: stable@kernel.org >> --- > > NACK for now, please give us a chance to review this -- this may > actually be correct. > >  Luis > >> --- a/drivers/net/wireless/ath/ath9k/ani.c      2009-06-24 21:14:00.000000000 -0700 >> +++ b/drivers/net/wireless/ath/ath9k/ani.c      2009-07-06 02:45:57.000000000 -0700 >> @@ -482,7 +482,7 @@ void ath9k_ani_reset(struct ath_hw *ah) >>                ath9k_hw_ani_control(ah, ATH9K_ANI_SPUR_IMMUNITY_LEVEL, 0); >>                ath9k_hw_ani_control(ah, ATH9K_ANI_FIRSTEP_LEVEL, 0); >>                ath9k_hw_ani_control(ah, ATH9K_ANI_OFDM_WEAK_SIGNAL_DETECTION, >> -                                    !ATH9K_ANI_USE_OFDM_WEAK_SIG); >> +                                    ATH9K_ANI_USE_OFDM_WEAK_SIG); >>                ath9k_hw_ani_control(ah, ATH9K_ANI_CCK_WEAK_SIGNAL_THR, >>                                     ATH9K_ANI_CCK_WEAK_SIG_THR); >> >> Does your AP operate on 2.4GHz band or 5GHz ? -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick