Return-path: Received: from senator.holtmann.net ([87.106.208.187]:54821 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbZGYNIT (ORCPT ); Sat, 25 Jul 2009 09:08:19 -0400 Subject: Re: [PATCH] mac80211: fix receiving deauth From: Marcel Holtmann To: Johannes Berg Cc: John Linville , linux-wireless , Reinette Chatre In-Reply-To: <1248515916.19945.1.camel@johannes.local> References: <1248515916.19945.1.camel@johannes.local> Content-Type: text/plain Date: Sat, 25 Jul 2009 15:07:25 +0200 Message-Id: <1248527245.28545.162.camel@violet> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Johannes, > Marcel reported a warning, which quite obviously comes > from an oversight in the code handling deauth frames, > and which resulted in multiple follow-up warnings due > to this missing handling. This patch adds the missing > deauth handling (telling cfg80211 about it) and also > removes the follow-up warnings since they could happen > due to races even if nothing is wrong. I've explained > the races in the comments. > > Signed-off-by: Johannes Berg > Reported-by: Marcel Holtmann so me current wireless-testing tree now contains the tree from today with the oops fix from Luiz, your lockdep fix, Reinette's iwlwifi updates and this one. No oopses so far and my connection to the AP stays stable. No immediate disconnects anymore. Everything looks good again. Tested-by: Marcel Holtmann Regards Marcel