Return-path: Received: from mail-fx0-f217.google.com ([209.85.220.217]:37085 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbZH3M6c (ORCPT ); Sun, 30 Aug 2009 08:58:32 -0400 From: Bartlomiej Zolnierkiewicz To: Zhu Yi Subject: Re: ipw2200: firmware DMA loading rework Date: Sun, 30 Aug 2009 14:37:42 +0200 Cc: Andrew Morton , Mel Gorman , Johannes Weiner , Pekka Enberg , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Mel Gorman , "netdev@vger.kernel.org" , "linux-mm@kvack.org" , James Ketrenos , "Chatre, Reinette" , "linux-wireless@vger.kernel.org" , "ipw2100-devel@lists.sourceforge.net" References: <20090826074409.606b5124.akpm@linux-foundation.org> <1251430951.3704.181.camel@debian> In-Reply-To: <1251430951.3704.181.camel@debian> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <200908301437.42133.bzolnier@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Friday 28 August 2009 05:42:31 Zhu Yi wrote: > Bartlomiej Zolnierkiewicz reported an atomic order-6 allocation failure > for ipw2200 firmware loading in kernel 2.6.30. High order allocation is s/2.6.30/2.6.31-rc6/ The issue has always been there but it was some recent change that explicitly triggered the allocation failures (after 2.6.31-rc1). > likely to fail and should always be avoided. > > The patch fixes this problem by replacing the original order-6 > pci_alloc_consistent() with an array of order-1 pages from a pci pool. > This utilized the ipw2200 DMA command blocks (up to 64 slots). The > maximum firmware size support remains the same (64*8K). > > This patch fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14016 > > Cc: Andrew Morton > Cc: Mel Gorman > Signed-off-by: Zhu Yi Thanks for the fix (also kudos to other people helping with the bugreport), it works fine so far and looks OK to me: Tested-and-reviewed-by: Bartlomiej Zolnierkiewicz