Return-path: Received: from mail-iw0-f204.google.com ([209.85.223.204]:40524 "EHLO mail-iw0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbZH0SZV (ORCPT ); Thu, 27 Aug 2009 14:25:21 -0400 Received: by iwn42 with SMTP id 42so688738iwn.33 for ; Thu, 27 Aug 2009 11:25:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20090827023000.21926.90867.stgit@mj.roinet.com> <40f31dec0908270558y2a3a565bvcc7e470b7f2644c6@mail.gmail.com> From: "Luis R. Rodriguez" Date: Thu, 27 Aug 2009 11:25:03 -0700 Message-ID: <43e72e890908271125x378da3abw41e7f73dd8fbfe81@mail.gmail.com> Subject: Re: [ath5k-devel] [PATCH 1/2] ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes() To: Bob Copeland Cc: Nick Kossifidis , Pavel Roskin , ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Aug 27, 2009 at 11:17 AM, Bob Copeland wrote: > On Thu, Aug 27, 2009 at 8:58 AM, Nick Kossifidis wrote: >> 2009/8/27 Pavel Roskin : > >> Current code works fine (i 've checked it against various cards), >> there is nothing wrong >> with having another function for reading turbo modes, i find it's >> cleaner that way. > > Well, we also don't use the turbo modes at all and that's where the > error is (IIRC) so it shouldn't have any impact. :) Again, why don't we just remove all that fucking turbo cruft? Luis