Return-path: Received: from mail-iw0-f204.google.com ([209.85.223.204]:44588 "EHLO mail-iw0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbZHXW3n convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2009 18:29:43 -0400 MIME-Version: 1.0 In-Reply-To: <1ba2fa240908241520q5be2060co145ec0745954dcf0@mail.gmail.com> References: <1251149659-32212-1-git-send-email-tomas.winkler@intel.com> <43e72e890908241436o5f30cfe6xa7bdda8b25ac082@mail.gmail.com> <1ba2fa240908241520q5be2060co145ec0745954dcf0@mail.gmail.com> From: "Luis R. Rodriguez" Date: Mon, 24 Aug 2009 15:29:24 -0700 Message-ID: <43e72e890908241529m3fb29676pa52a9db44029c52f@mail.gmail.com> Subject: Re: [PATCH 1/1] iwmc3200: add more SDIO device ids To: Tomas Winkler Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Greg KH Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Aug 24, 2009 at 3:20 PM, Tomas Winkler wrote: > On Tue, Aug 25, 2009 at 12:36 AM, Luis R. Rodriguez wrote: >> On Mon, Aug 24, 2009 at 2:34 PM, Tomas Winkler wrote: >>> add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids >>> >>> Cc:inaky.perez-gonzalez@intel.com >>> Cc:cindy.h.kao@intel.com >>> Cc:yi.zhu@intel.com >>> Signed-off-by: Tomas Winkler >> >> Since it seems we are preferring to not do this for PCI for cases >> where the ID will only be used for 1 device perhaps its best to remove >> all those ids and stuff them directly into the intel driver itself >> that will use it. >> > I don't have strong opinion about it but this is the current habit > IIRC there was a mail thread that explicitly asked to move SDIO IDs > there,  of course I cannot locate it right now :( Sure, understood, whoever maintains this should decide. Luis