Return-path: Received: from smtp.nokia.com ([192.100.105.134]:44459 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755043AbZHKSlj (ORCPT ); Tue, 11 Aug 2009 14:41:39 -0400 Message-ID: <4A81BB47.2020607@nokia.com> Date: Tue, 11 Aug 2009 21:41:11 +0300 From: Luciano Coelho MIME-Version: 1.0 To: ext Stephen Rothwell CC: "linux-wireless@vger.kernel.org" , "linville@tuxdriver.com" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs References: <1249981107-21746-1-git-send-email-luciano.coelho@nokia.com> <20090811200746.cde6aed9.sfr@canb.auug.org.au> In-Reply-To: <20090811200746.cde6aed9.sfr@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: ext Stephen Rothwell wrote: > Hi Luciano, > > On Tue, 11 Aug 2009 11:58:27 +0300 Luciano Coelho wrote: > >> +++ b/drivers/net/wireless/wl12xx/wl1271_boot.c >> @@ -100,8 +100,8 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf, >> >> wl1271_debug(DEBUG_BOOT, "starting firmware upload"); >> >> - wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d", fw_data_len, >> - CHUNK_SIZE); >> + wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d", >> + (u32) fw_data_len, CHUNK_SIZE); >> > > fw_data_len is a size_t and so should be printed with %zd. > > >> @@ -148,7 +148,7 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf, >> addr = dest + chunk_num * CHUNK_SIZE; >> p = buf + chunk_num * CHUNK_SIZE; >> wl1271_debug(DEBUG_BOOT, "uploading fw last chunk (%d B) 0x%p to 0x%x", >> - fw_data_len % CHUNK_SIZE, p, addr); >> + (u32) fw_data_len % CHUNK_SIZE, p, addr); >> > > ditto. > Thanks! I didn't know about the z length modifier for printf (everyday learning something new!), I should have checked the manpage. I'll fix this and send v2 of my patch. -- Cheers, Luca.