Return-path: Received: from mail-ew0-f214.google.com ([209.85.219.214]:63643 "EHLO mail-ew0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754560AbZHJOET (ORCPT ); Mon, 10 Aug 2009 10:04:19 -0400 Date: Mon, 10 Aug 2009 18:04:14 +0400 From: Cyrill Gorcunov To: Roel Kluin Cc: Michael Buesch , Daniel Mack , "John W. Linville" , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Libertas: Association request to the driver failed Message-ID: <20090810140414.GA5207@lenovo> References: <20090807191156.GS19257@buzzloop.caiaq.de> <20090809102417.GH13639@buzzloop.caiaq.de> <4A7EAED8.9090900@gmail.com> <200908091310.56919.mb@bu3sch.de> <20090809191359.GG4805@lenovo> <4A7FF84C.7070708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4A7FF84C.7070708@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: [Roel Kluin - Mon, Aug 10, 2009 at 12:37:00PM +0200] ... | > I saw one pattern in trace code (not sure if it's | > still there) but personally don't like dynamic | > stack arrays (though at moment the max value | > being passed into routine is known maybe just | > use MAX_RATES instead of (*rates_size)?). Hmm? | | Good point. | | > -- Cyrill | | Thanks, | | I think there was another problem in lbs_associate(), | the memcpy already affected rates->rates. | Yeah, something like that. Note that I was only cared about stack so I didn't dive into details of this code :) I suppose wireless mainteiners will review it more precisely. Thanks Roel! -- Cyrill