From: Michael Buesch <mb@bu3sch.de>
To: =?utf-8?q?G=C3=A1bor_Stefanik?= <netrolller.3d@gmail.com>
Subject: Re: [PATCH RESEND] b43: implement baseband init for LP-PHY <= rev1
Date: Mon, 3 Aug 2009 11:13:37 +0200
Cc: John Linville <linville@tuxdriver.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Broadcom Wireless <bcm43xx-dev@lists.berlios.de>
References: <4A7610AE.5000908@gmail.com>
In-Reply-To: <4A7610AE.5000908@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Message-Id: <200908031113.38229.mb@bu3sch.de>
Sender: linux-wireless-owner@vger.kernel.org

On Monday 03 August 2009 00:18:22 Gábor Stefanik wrote:
> Implement baseband init for rev.0 and rev.1 LP PHYs. Convert
> boardflags_hi values to defines.
> Implement b43_phy_copy for easier copying between registers, as needed
> by LP-PHY init.

> +	if (bus->sprom.boardflags_hi&  B43_BFH_FEM_BT)&&
> +	   (bus->chip_id == 0x5354)&&
> +	   (bus->chip_package == SSB_CHIPPACK_BCM4712S)) {
> +		b43_phy_set(dev, B43_LPPHY_CRSGAIN_CTL, 0x0006);
> +		b43_phy_write(dev, B43_LPPHY_GPIO_SELECT, 0x0005);
> +		b43_phy_write(dev, B43_LPPHY_GPIO_OUTEN, 0xFFFF);
> +		b43_hf_write(dev, b43_hf_read | 0x0800ULL<<  32);
> +	}

The HF write is wrong. Read the specification:
http://bcm-v4.sipsolutions.net/802.11/Mhf

Patch otherwise looks ok.
-- 
Greetings, Michael.