Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:51190 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932905AbZHVVnq (ORCPT ); Sat, 22 Aug 2009 17:43:46 -0400 From: Christian Lamparter To: Joerg Albert Subject: Re: [RFT] ar9170: use eeprom's frequency calibration values Date: Sat, 22 Aug 2009 23:43:16 +0200 Cc: "linux-wireless" , John Linville , Johannes Berg References: <200908212252.41053.chunkeey@web.de> <200908220151.19792.chunkeey@web.de> <4A905D2B.9090405@gmx.de> In-Reply-To: <4A905D2B.9090405@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <200908222343.16682.chunkeey@web.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday 22 August 2009 23:03:39 Joerg Albert wrote: > On 08/22/2009 01:51 AM, Christian Lamparter wrote: > > On Saturday 22 August 2009 01:36:17 Joerg Albert wrote: > >> On 08/21/2009 10:52 PM, Christian Lamparter wrote: > >>> This patch adds some more bits from the vendor driver, which > >>> are supposed to help users with the one-stage/openfw firmwares. > >> The otus driver sets phy registers 672-703 only for the one-stage firmware - > >> hal/hpmain.c, line 3445: > >> > >> #ifndef ZM_OTUS_LINUX_PHASE_2 > >> reg_write(regAddr + i, val); /* CR672 */ > >> #endif > >> > >> Are you sure it doesn't hurt with the two-stage firmware? > > no idea, that's why I ask requested input, instead of posting a patch + > > sob right away. > > > > so far, I haven't heard of or experienced any regressions or anomalies. > > Do you already have comments or complains? :) > > Your patch works fine here with a WNDA3100, using the two-stage firmware, against > a 802.11g AP. After "iwconfig wlan1 rate 54M" I get approx. 22 MBit/s throughput > with iperf, same as without the patch. same here... and not really surprising. According to my sources, the two-stage firmware is capable of doing calibration without extra help from the host. > > Unfortunately, my device (WNDA3100) still doesn't work properly > > with either version at phy-rates beyond the magic 18MBit barrier. > > Strange, same device here (or another hw version? FCC ID: PY307300073) > and I see packets @ 54M from the dev in the sniffer. But it also has the > invalid regdomain 0x8000 in the eeprom ... that comment about "18mbit barrier" is only true for the one-stage fw. I've no problem getting up and slightly above 80mbits with the original two-stage fw. Regards, Chr