Return-path: Received: from rv-out-0506.google.com ([209.85.198.230]:31329 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbZHNUn1 (ORCPT ); Fri, 14 Aug 2009 16:43:27 -0400 Received: by rv-out-0506.google.com with SMTP id f6so497156rvb.1 for ; Fri, 14 Aug 2009 13:43:29 -0700 (PDT) Message-ID: <4A85CC6C.1030005@lwfinger.net> Date: Fri, 14 Aug 2009 15:43:24 -0500 From: Larry Finger MIME-Version: 1.0 To: =?UTF-8?B?R8OhYm9yIFN0ZWZhbmlr?= CC: John Linville , Michael Buesch , Mark Huijgen , linux-wireless , Broadcom Wireless Subject: Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration References: <4A85B8DE.3000704@gmail.com> In-Reply-To: <4A85B8DE.3000704@gmail.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Gábor Stefanik wrote: > Call set_tx_power_control with a LPPHY_TXPCTL rather than an > LPPHY_TX_PWR_CTL_CMD_MODE. > > Signed-off-by: Gábor Stefanik > --- > This should fix the WARN_ON testers were seeing during init. > > drivers/net/wireless/b43/phy_lp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c > index adfa7bf..558224b 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev) > old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) & > B43_LPPHY_TX_PWR_CTL_CMD_MODE; > > - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF); > + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF); > lpphy_disable_crs(dev); > loopback = lpphy_loopback(dev); > if (loopback == -1) With this one, I still get WARNING: at drivers/net/wireless/b43/phy_lp.c:1006 lpphy_set_tx_power_control+0xbf/0xdd [b43](). To get rid of them, I need to modify the enum b43_lpphy_txpctl_mode{} as I wrote earlier. I'm also seeing the interface stopped and restarted. I'll try to track that down. Larry