Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]:16868 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbZHQTdB convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2009 15:33:01 -0400 Received: by fg-out-1718.google.com with SMTP id e12so456243fga.17 for ; Mon, 17 Aug 2009 12:33:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A85B8DE.3000704@gmail.com> References: <4A85B8DE.3000704@gmail.com> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Mon, 17 Aug 2009 21:32:42 +0200 Message-ID: <69e28c910908171232i6828d42bh3aac1d236f789c91@mail.gmail.com> Subject: Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration To: John Linville , Michael Buesch , Larry Finger , Mark Huijgen Cc: Broadcom Wireless , linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/8/14 G?bor Stefanik : > Call set_tx_power_control with a LPPHY_TXPCTL rather than an > LPPHY_TX_PWR_CTL_CMD_MODE. > > Signed-off-by: G?bor Stefanik > --- > This should fix the WARN_ON testers were seeing during init. > > drivers/net/wireless/b43/phy_lp.c | ? ?2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/b43/phy_lp.c > b/drivers/net/wireless/b43/phy_lp.c > index adfa7bf..558224b 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev > *dev) > ? ? ? ?old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) & > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?B43_LPPHY_TX_PWR_CTL_CMD_MODE; > > - ? ? ? lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF); > + ? ? ? lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF); > ? ? ? ?lpphy_disable_crs(dev); > ? ? ? ?loopback = lpphy_loopback(dev); > ? ? ? ?if (loopback == -1) > -- > 1.6.2.4 > John, any news on this one? I can't see it in wireless testing. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)