Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:5846 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933060AbZHEFsp convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2009 01:48:45 -0400 Received: by fg-out-1718.google.com with SMTP id e12so809538fga.17 for ; Tue, 04 Aug 2009 22:48:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A78F0DC.4070104@lwfinger.net> References: <4A78C336.9000503@gmail.com> <4A78F0DC.4070104@lwfinger.net> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Wed, 5 Aug 2009 07:48:25 +0200 Message-ID: <69e28c910908042248m5419a39fl5f370e73e01e8b64@mail.gmail.com> Subject: Re: [PATCH V3] b43: implement baseband init for LP-PHY <= rev1 To: John Linville , Larry Finger Cc: Michael Buesch , Broadcom Wireless , linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/8/5 Larry Finger : > G?bor Stefanik wrote: >> Implement baseband init for rev.0 and rev.1 LP PHYs. Convert >> boardflags_hi values to defines. >> Implement b43_phy_copy for easier copying between registers, as needed >> by LP-PHY init. >> >> Signed-off-by: G?bor Stefanik >> Cc: Michael Buesch >> Cc: Larry Finger >> --- >> V3: >> -Added FIXME to the b43_hf_write call. >> -The b43_hf_write call now uses a #defined value, rather than a magic >> number. > > It looks to me that V2 was put into wireless-testing. You will need to > prepare a separate patch to make the V2 => V3 changes. > > Larry OK, I will be sending one today. Note to John: Please apply the "Fix fallout" patch, but not the "Cleanups" one. The second part of "Cleanups" will be resubmitted, combined with other V2->V3 changes. Larry, my next target is http://bcm-v4.sipsolutions.net/802.11/PHY/LP/SYNCHSTX - however, what is the definition of struct lpphy_extstxdata_t? Where does the stx array get its values (or what are its initial values, if it needs to be initialized here)? Also, with Sync-STX, >=rev2 radio init is essentially complete, except for "with interrupts disabled, do something with backplane (TODO)" - when can we expect documentation on this step? -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)