Return-path: Received: from kroah.org ([198.145.64.141]:41814 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbZHFGBF (ORCPT ); Thu, 6 Aug 2009 02:01:05 -0400 Date: Wed, 5 Aug 2009 22:09:32 -0700 From: Greg KH To: Marcel Holtmann Cc: "Luis R. Rodriguez" , linville@tuxdriver.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, zhifeng.cai@atheros.com, stephen.chen@atheros.com, linux-usb@vger.kernel.org Subject: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID Message-ID: <20090806050932.GA25015@kroah.com> References: <1249523981-26601-1-git-send-email-lrodriguez@atheros.com> <1249532170.21101.3.camel@localhost.localdomain> <43e72e890908052126v53aa1b4sb7a48e19f98fdfa6@mail.gmail.com> <1249533357.21101.5.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1249533357.21101.5.camel@localhost.localdomain> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 05, 2009 at 09:35:57PM -0700, Marcel Holtmann wrote: > Hi Luiz, > > > >> New Atheros USB devices will use 0x0cf3. The first device > > >> will be ar9271, for which we are adding support for. > > >> > > >> Cc: zhifeng.cai@atheros.com > > >> Cc: stephen.chen@atheros.com > > >> Signed-off-by: Luis R. Rodriguez > > >> --- > > >> > > >> John, sending this through you as this is only > > >> specific to wireless, at least at the moment. > > >> > > >> include/linux/pci_ids.h | 1 + > > >> 1 files changed, 1 insertions(+), 0 deletions(-) > > >> > > >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > >> index 73b46b6..27f4e6b 100644 > > >> --- a/include/linux/pci_ids.h > > >> +++ b/include/linux/pci_ids.h > > >> @@ -2170,6 +2170,7 @@ > > >> #define PCI_DEVICE_ID_BCM1250_HT 0x0002 > > >> > > >> #define PCI_VENDOR_ID_ATHEROS 0x168c > > >> +#define PCI_VENDOR_ID_ATHEROS_USB 0x0cf3 > > > > > > this is confusing the hell out of me. What are you adding here. > > > > No you're right, my fault. > > > > > A USB > > > vendor id or a PCI one. Is the ar9271 a PCI device or a USB device? > > > > Its only USB. > > > > Thanks... hm I see no USB vendor id headers. Guess we won't need to add this. > > the closest we have is drivers/hid/hid-ids.h and we might just should > have Greg create a usb-ids.h file. Ick, no, there's no such file for a good reason. Put your device ids in the driver files, no need to share it across the whole kernel. thanks, greg k-h