Return-path: Received: from ey-out-2122.google.com ([74.125.78.26]:9816 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbZHCRys (ORCPT ); Mon, 3 Aug 2009 13:54:48 -0400 Received: by ey-out-2122.google.com with SMTP id 9so987450eyd.37 for ; Mon, 03 Aug 2009 10:54:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1249115316.2007.0.camel@johannes.local> References: <20090731181020.GE7963@makis> <20090801054649.GA8390@makis> <4A73FA8D.5030804@gmail.com> <1249114918.26584.18.camel@johannes.local> <4A73FBBD.3070507@gmail.com> <1249115316.2007.0.camel@johannes.local> Date: Mon, 3 Aug 2009 20:54:47 +0300 Message-ID: <40f31dec0908031054m3b8231fdrf36f363702218116@mail.gmail.com> Subject: Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration From: Nick Kossifidis To: Johannes Berg Cc: Jiri Slaby , linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org, linville@tuxdriver.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2009/8/1 Johannes Berg : > On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote: >> On 08/01/2009 10:21 AM, Johannes Berg wrote: >> > Actually, jiffies are unsigned long >> >> Yeah, this is what I meant. I agree I messed it up when I didn't write >> the unsigned explicitly. It might have been confusing, thanks for >> pointing out. > > And, in addition to what you said, the code shouldn't divide jiffies, it > should multiply the timeout, add it to the start time, and then use > time_is_after_jiffies() or so. > > johannes ACK will resend asap ;-) -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick