Return-path: Received: from mail-fx0-f217.google.com ([209.85.220.217]:47480 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754559AbZIKQHU (ORCPT ); Fri, 11 Sep 2009 12:07:20 -0400 To: Michael Buesch Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Johannes Berg , "John W. Linville" Subject: Re: mac80211: NOHZ: local_softirq_pending 08 References: <200909111648.50902.mb@bu3sch.de> <877hw534wd.fsf@litku.valot.fi> <200909111707.23971.mb@bu3sch.de> From: Kalle Valo Date: Fri, 11 Sep 2009 19:07:20 +0300 In-Reply-To: <200909111707.23971.mb@bu3sch.de> (Michael Buesch's message of "Fri\, 11 Sep 2009 17\:07\:23 +0200") Message-ID: <873a6t31on.fsf@litku.valot.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Michael Buesch writes: >> > mac80211 (or some other part of the networking stack) triggers this >> > warning in the NOHZ code: NOHZ: local_softirq_pending 08 >> > >> > 08 seems to be NET_RX_SOFTIRQ. >> > >> > It happens, because my test driver b43 handles all RX and TX-status >> > callbacks in process context. I guess some part of the networking >> > stack expects RX to be in tasklet and/or softirq context. >> > >> > We also have a report of this warning in wl1251, so it's probably not >> > a b43 problem. >> >> Yes, I see this with wl1251. It uses workqueues everywhere. >> > > This patch seems to fix it. Yes, it does. Thanks. > Signed-off-by: Michael Buesch Tested-by: Kalle Valo -- Kalle Valo