Return-path: Received: from mail-fx0-f217.google.com ([209.85.220.217]:49401 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbZIBRo6 (ORCPT ); Wed, 2 Sep 2009 13:44:58 -0400 Received: by fxm17 with SMTP id 17so964685fxm.37 for ; Wed, 02 Sep 2009 10:45:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1251912629.2999.1.camel@johannes.local> References: <1251906970.13180.137.camel@rc-desk> <1251910457.13180.160.camel@rc-desk> <1251911029.2999.0.camel@johannes.local> <1251911825.13180.173.camel@rc-desk> <1251912629.2999.1.camel@johannes.local> Date: Wed, 2 Sep 2009 13:38:42 -0400 Message-ID: Subject: Re: [PATCH 2.6.31] iwlwifi: Reenable power_level From: Andrew Lutomirski To: Johannes Berg Cc: reinette chatre , "linux-wireless@vger.kernel.org" , "Zhu, Yi" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Sep 2, 2009 at 1:30 PM, Johannes Berg wrote: > Hi Reinette, > >> The file itself was removed, but from what I understand the same >> functionality can now be obtained from sleep_level_override. > > Indeed. > >> Users who >> previously used power_level can thus now use sleep_level_override, but >> with sleep_level_override not existing in 2.6.31 they will have no >> alternative if we remove power_level. >> >> > So it >> > may be fair to remove it for .31 since there you can't use it anyway. >> >> You can still use it to manually set power index used by device to >> reduce power usage. > > I was under the impression that Andrew said this actually didn't work. Exactly. My patch fixes that, although there might be a better way to do that. --Andy > > johannes >